[systemd-devel] [systemd-commits] Makefile.am

[Lennart Poettering]

On Fri, 29.05.15 03:03, Daniel Mack (zonque at kemper.freedesktop.org) wrote:

>  Makefile.am |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> New commits:
> commit 6096d9ccc3f0b963010a47febce7e44c8632c23b
> Author: Daniel Mack <daniel at zonque.org>
> Date:   Fri May 29 12:00:58 2015 +0200
> 
>     Makefile: make custom-entities.ent depend on Makefile.am
>     
>     When Makefile.am is modified, make sure custom-entities.ent is rebuilt.
>     After all, $(substitutions) is defined there, so changes of that variable
>     must be reflected in the resulting file.

Hmm, so we used have a lot of rules like this that mathematically
correctly rebuilt really everything touched by a change. However, this
resulted in soo much wasted build time, that we removed parts of it
again, even if this means that some man pages might be slightly out of
date if the Makefile.am changes.

hence: what is the impact of this change precisely? does this mean a
slight change of the makefile will always result in all man pages to
be rebuilt? we don#t do that for the C compilation logic when a
Makefile.am changes, so should we do this in this case?



> 
> diff --git a/Makefile.am b/Makefile.am
> index e4a8616..e18bb5c 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -6602,7 +6602,7 @@ EXTRA_DIST += \
>  
>  # ------------------------------------------------------------------------------
>  if ENABLE_MANPAGES
> -man/custom-entities.ent: configure.ac
> +man/custom-entities.ent: Makefile.am configure.ac
>  	$(AM_V_GEN)$(MKDIR_P) $(dir $@)
>  	$(AM_V_GEN)(echo '<?xml version="1.0" encoding="utf-8" ?>' && \
>  	 printf '$(subst '|,<!ENTITY ,$(subst =, ",$(subst |',">\n,$(substitutions))))') \
> 
> _______________________________________________
> systemd-commits mailing list
> systemd-commits at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-commits


Lennart

-- 
Lennart Poettering, Red Hat