[systemd-devel] [PATCH v2] cgroup-util: fix is_valid check to pass for unified cgroup hierchy.

[Lennart Poettering]

On Fri, 29.05.15 15:52, Dimitri John Ledkov (dimitri.j.ledkov at intel.com) wrote:

> > And yeah, getting proper notifications especially for the container
> > case is the most important thing for me too.
> 
> Right. I have it as compile option at the moment, and i'm booting
> fresh VMs with it. I do something rather crazy at the moment - mount
> /sys/fs/cgroup/systemd as unified hiearchy whilst keeping the old
> controller mounts where they are. Will add the bits for the inotify
> watches and then publish an RFC patch set. This way systemd gains the
> notification benefit straight away, whilst keeping the rest as it was
> essentially. I take it the unitfied structure is expected to be
> mounted in /sys/fs/cgroup/ direct, once stable.

I'd rather not support half-way implementations like that.

I'd really just introduce a new kernel cmdline option:
systemd.debug-unified-cgroup=1 or so. A simple boolean that gets you
either one or the other behaviour. Maybe make the default for this
setting configurable with a configure script switch. And I'd include
the "debug" in the name, to indicate that this is just for testing for
now, and is an option that will go away eventually.

Lennart

-- 
Lennart Poettering, Red Hat