[systemd-devel] [PATCH 1/2] configure.ac: strip off trailing slashed from $rootprefix

[Michael Biebl]

2015-05-30 2:05 GMT+02:00 Daniel Mack <daniel at zonque.org>:
> Make sure the variable set via --with-rootprefix= does not contain a
> trailing slash, so man pages can use entities like "&rootprefix;/lib"
> without ending up having double slashes.
> ---
>  configure.ac | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 92654a6..55b73de 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1396,7 +1396,8 @@ AC_ARG_WITH([zshcompletiondir],
>
>  AC_ARG_WITH([rootprefix],
>          AS_HELP_STRING([--with-rootprefix=DIR], [rootfs directory prefix for config files and kernel modules]),
> -        [], [with_rootprefix=${ac_default_prefix}])
> +        [with_rootprefix=`echo ${withval} | sed -e s,/*$,,`],
> +        [with_rootprefix=${ac_default_prefix}])
>
>  AC_ARG_WITH([rootlibdir],
>          AS_HELP_STRING([--with-rootlibdir=DIR], [Root directory for libraries necessary for boot]),

autoconf already strips trailing slashes for all default directory
variables [1].
I think we should do the same for *all* our custom --with-$foo-dir
variables, not just rootlibdir.

Maybe provide a custom macro for that and apply that to

  --with-html-dir=PATH    path to installed docs
  --with-efi-libdir=PATH  Path to EFI lib directory
  --with-efi-ldsdir=PATH  Path to EFI lds directory
  --with-efi-includedir=PATH
  --with-dbuspolicydir=DIR
  --with-dbussessionservicedir=DIR
  --with-dbussystemservicedir=DIR
  --with-bashcompletiondir=DIR
  --with-zshcompletiondir=DIR
  --with-rootprefix=DIR   rootfs directory prefix for config files and kernel
  --with-rootlibdir=DIR   Root directory for libraries necessary for boot
  --with-pamlibdir=DIR    Directory for PAM modules
  --with-pamconfdir=DIR   Directory for PAM configuration

WDYT?

[1] http://comments.gmane.org/gmane.comp.sysutils.autoconf.bugs/5747
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?