[systemd-devel] [PATCH 1/2] arm/aarch64: detect-virt: check dmi

[Andrew Jones]

On Wed, Nov 04, 2015 at 11:52:03AM +0100, Lennart Poettering wrote:
> On Tue, 03.11.15 15:19, Andrew Jones (drjones at redhat.com) wrote:
> 
> > ---
> >  src/basic/virt.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/src/basic/virt.c b/src/basic/virt.c
> > index fb181e5b55ee5..b0e33dc5f4d24 100644
> > --- a/src/basic/virt.c
> > +++ b/src/basic/virt.c
> > @@ -34,7 +34,7 @@
> >  
> >  static int detect_vm_cpuid(void) {
> >  
> > -        /* Both CPUID and DMI are x86 specific interfaces... */
> > +        /* CPUID is an x86 specific interface. */
> >  #if defined(__i386__) || defined(__x86_64__)
> >  
> >          static const struct {
> > @@ -144,9 +144,7 @@ static int detect_vm_device_tree(void) {
> >  }
> >  
> >  static int detect_vm_dmi(void) {
> > -
> > -        /* Both CPUID and DMI are x86 specific interfaces... */
> > -#if defined(__i386__) || defined(__x86_64__)
> > +#if defined(__i386__) || defined(__x86_64__) || defined(__arm__) ||
> > -defined(__aarch64__)
> 
> Hmm, is DMI really something that is deployed on non-64bit arm?

Yup. It requires booting the 32-bit arm guest with UEFI (AAVMF), but
the QEMU machine model (mach-virt) doesn't treat 64-bit vs. 32-bit
differently in this respect.

Thanks,
drew

> 
> 
> Lennart
> 
> -- 
> Lennart Poettering, Red Hat