[systemd-devel] [PATCH] v3 Read NIC partitions on Dell Servers

[Lennart Poettering]

On Tue, 10.11.15 14:57, jharg93 at gmail.com (jharg93 at gmail.com) wrote:

> From: Jordan Hargrave <jharg93 at gmail.com>
> 
> I removed the SMBIOS-specific code, this code is for partition detection only.
> 
> This patch will read NIC partition info from VPD on Dell Servers
> 
> It creates a new environment variable 'ID_NET_NAME_PARTITION'
> with the format '<port>_<partition>'
> 
> Signed-off-by: Jordan Hargrave <jharg93 at gmail.com>

I am not sure if Kay/Tom want this patch at all or not, but if they
do:

please have a look at CODING_STYLE, and try to follow the rules. I see
quite a few places where coding style isn't followed: we don't use
S-o-b on systemd, we place opening brackets on the same line as the
functions/structs. We don't use types such as "unsigned char", we
don't invent error codes such as "-1", we don't use {} on single-line
if blocks, and so on.

Lennart

-- 
Lennart Poettering, Red Hat