[systemd-devel] PATCH: src/udev/ata_id/ata_id.c: WWN recognition fails on big-endian systems

[Lennart Poettering]

On Fri, 18.09.15 19:44, Tom Lyon (pugs at drivescale.com) wrote:

> --- a/src/udev/ata_id/ata_id.c
> +++ b/src/udev/ata_id/ata_id.c
> @@ -485,6 +485,10 @@ int main(int argc, char *argv[])
>                  disk_identify_fixup_uint16(identify.byte,  90);     /*
> time required for enhanced SECURITY ERASE UNIT */
>                  disk_identify_fixup_uint16(identify.byte,  91);     /*
> current APM values */
>                  disk_identify_fixup_uint16(identify.byte,  94);     /*
> current AAM value */
> +                disk_identify_fixup_uint16(identify.byte, 108);     /* wwn
> */
> +                disk_identify_fixup_uint16(identify.byte, 109);     /* wwn
> */
> +                disk_identify_fixup_uint16(identify.byte, 110);     /* wwn
> */
> +                disk_identify_fixup_uint16(identify.byte, 111);     /* wwn
> */
>                  disk_identify_fixup_uint16(identify.byte, 128);     /*
> device lock function */
>                  disk_identify_fixup_uint16(identify.byte, 217);     /*
> nominal media rotation rate */
>                  memcpy(&id, identify.byte, sizeof id);

Your mailer has broken the lines of this patch. Please consider
submitting via github, where these issues cannot happen.

https://github.com/systemd/systemd/

Also, against version of systemd is this patch supposed to be? Before
or after 01f61d331bb5038f0c877ac03c54333328b6ea28?

Lennart

-- 
Lennart Poettering, Red Hat