[systemd-devel] [Question] timezones in timers

[Lennart Poettering]

On Sa, 09.09.17 21:16, Ivan Kurnosov (zerkms at zerkms.ru) wrote:

> Hi,
> 
> I've implemented support for timezones in timers (at least I am not sure if
> there are some other places that need some changes).
> 
> Here is a diff of what I've committed so far:
> https://github.com/systemd/systemd/compare/master...zerkms:TIMER_TIMEZONE
> 
> In the very bottom in the tests file you may see what is supported and how.
> In short:
> 
> the IANA timezone name are supported. Basically, any timezone from the
> `timedatectl list-timezones` output is supported.
> 
> The most basic example of the timer:
> 
> 2017-09-09 20:42:00 Pacific/Auckland
> 
> 
> Implementation takes into account standard/summer time change.
> 
> Implementation might be improved further via a small refactoring to remove
> the `CalendarSpec::utc` field, since it effectively is not necessary now,
> given that one may use `spec->timezone = "UTC";` instead.
> 
> I'm looking for your feedback,

If you are confident that your code is somewhat complete now, please
submit it as PR on github, that's how we usually track submissions and
do codereview. it doesn't matter if you are a little bit unsure about
your code, or super confident, it's all handled through the PR
scheme. That way, everybody who works on systemd will get notified
about your code, the CI analyzes your code and we can do our review.

Thank you,

Lennart

-- 
Lennart Poettering, Red Hat