[systemd-devel] [PATCH] rules: load drivers only on "add" events

[Dmitry Torokhov]

On Tue, Sep 12, 2017 at 01:38:00PM +0200, Lennart Poettering wrote:
> On Mo, 11.09.17 11:47, Dmitry Torokhov (dmitry.torokhov at gmail.com) wrote:
> 
> > Previously we were loading kernel modules on all device events save
> > for "remove". With the introduction of KOBJ_BIND/KOBJ_UNBIND this causes
> > issues, as driver modules that have devices bound to their drivers get
> > immediately reloaded, and it appears to the user that module unloading
> > does not work.
> > 
> > Let's change the rules to only load modules on "add" events instead.
> > ---
> > 
> > As a side note, I am confused about handling authorship information in
> > systemd repository. The commit 9a39e1ce314d1a6f8a754f6dab040019239666a9
> > adding handling of bind/unbind actions is clearly taken from the email I
> > posted on systemd-devel mailing list on the 31st, however it lists
> > Lennart's name as the author?
> 
> Oh sorry. As Mantas pointed out, the preferred way to accept patches
> is via github PRs these days. To be friendly to submitters used to
> old-style kernel submissions we have a bot running that permits us to
> create a PR for your from patches submitted to the mailing list. PRs
> created by the bot are assigned to the person who clicked on the bot's
> email, which in this case was me. In github these PRs hence show up as
> owned by me, but the invidual commits in them are still attributed to
> you. But then, for single-patch PRs we don't do merges but
> rebase+fforward, which github has an explicit button in its UI
> for. But that rebase is kinda broken conceptually by them: it rewrites
> the commits of the PR as a single commit attributed to the person who
> clicked the button, losing all of the original attribution.
> 
> Quite frankly, it's a mess, and a serious brokeness in the github
> UI. Anyway, sorry for the confusion, it was definitely not my
> intention to steal your commits.

No worries, this commit is not something I would worry about too much, I
just wanted to raise the issue in general.

> 
> I figure in future we should keep in mind to never use github's
> "rebase" merge button for PRs that include commits from people who are
> not the PR owners. We should use real merges for all such cases to
> avoid such fuck-ups.
> 
> For your new patch the bot's notification is this btw:
> 
> https://lists.freedesktop.org/archives/systemd-devel/2017-September/039513.html
> 
> And I clicked on the link it provides now, so further discussion
> should now happen in this github PR:
> 
> https://github.com/systemd/systemd/pull/6802
> 
> Anyway, patch looks fine. Will merge as soon as the CI passes (and
> this time with a real merge so that the attribution isn't lost)
> 
> And please consider submitting patches as github PRs right-away,
> that's our preferred workflow these days.

OK, if I have more changes I'll do it through github (I do have an
account there, it's just my workflow and tools all geared towards
mailing list patch submission).

Thanks!

-- 
Dmitry