[systemd-devel] [PATCH v2 BlueZ] hid2hci: Fix udev rules for linux-4.14+

Ville Syrjala ville.syrjala at linux.intel.com
Tue Dec 4 20:41:17 UTC 2018


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

Since commit 1455cf8dbfd0 ("driver core: emit uevents when
device is bound to a driver") the kernel started emitting
"bind" and "unbind" uevents which confuse the hid2hci
udev rules.

The symptoms on an affected machine (Dell E5400 in my case)
include bluetooth devices not appearing and udev hogging
the cpu as it's busy processing a constant stream of these
"bind"+"unbind" uevents.

Change the udev rules not do anything except for "add" and
"change" events. This seems to cure my machine at least.

v2: Don't mess up "change" (Zbyszek)
    Fix up the commit message a bit

Cc: Dmitry Torokhov <dmitry.torokhov at gmail.com>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: Marcel Holtmann <marcel at holtmann.org>
Cc: Kay Sievers <kay.sievers at vrfy.org>
Cc: Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>
Cc: systemd-devel at lists.freedesktop.org
Cc: linux-kernel at vger.kernel.org
Cc: linux-bluetooth at vger.kernel.org
---
Reposting with BlueZ in subject and sob stripped. Maybe that helps in
getting a oneliner merged?

 tools/hid2hci.rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/hid2hci.rules b/tools/hid2hci.rules
index db6bb03d2ef3..5c7208af7a02 100644
--- a/tools/hid2hci.rules
+++ b/tools/hid2hci.rules
@@ -1,6 +1,6 @@
 # do not edit this file, it will be overwritten on update
 
-ACTION=="remove", GOTO="hid2hci_end"
+ACTION!="add|change", GOTO="hid2hci_end"
 SUBSYSTEM!="usb*", GOTO="hid2hci_end"
 
 # Variety of Dell Bluetooth devices - match on a mouse device that is
-- 
2.16.4



More information about the systemd-devel mailing list