[systemd-devel] Using systemd.offline-updates from an ostree based system

Richard Hughes hughsient at gmail.com
Thu May 2 11:16:32 UTC 2019


On Mon, 29 Apr 2019 at 10:16, Lennart Poettering <mzerqung at 0pointer.de> wrote:
> Please rewrite this as `FOREACH_STRING(fn, "/system-update/,
> "/etc/system-update") …` and then exit fatally with an error if
> laccess() fails with any error != ENOENT. In the above failures to
> laccess() /system-update are handled differently from those handling
> /etc/system-update...

Okay, thanks.

> Why a new service? We already have system-update-cleanup.service for
> this purpose, no?

Right, but system-update-cleanup.service is covering all kinds of
corner-cases -- We'd need to use ConditionPathExistsGlob and
ConditionPathIsSymbolicLinkGlob, the latter which does not exist. It
seemed so much simpler and easier to understand to copy and paste it
into a new service.

> Please submit as PR via github!

Done: https://github.com/systemd/systemd/pull/12464

Richard.


More information about the systemd-devel mailing list