[systemd-devel] [PATCH] ask-password: prevent buffer overrow when reading from keyring

Thadeu Lima de Souza Cascardo cascardo at canonical.com
Mon May 13 19:58:01 UTC 2019

When we read from keyring, a temporary buffer is allocated in order to
determine the size needed for the entire data. However, when zeroing that area,
we use the data size returned by the read instead of the lesser size allocate
for the buffer.

That will cause memory corruption that causes systemd-cryptsetup to crash
either when a single large password is used or when multiple passwords have
already been pushed to the keyring.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
 src/shared/ask-password-api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/ask-password-api.c b/src/shared/ask-password-api.c
index ab0c34692f1c..6c0a36990291 100644
--- a/src/shared/ask-password-api.c
+++ b/src/shared/ask-password-api.c
@@ -80,7 +80,7 @@ static int retrieve_key(key_serial_t serial, char ***ret) {
                 if (n < m)
-                explicit_bzero_safe(p, n);
+                explicit_bzero_safe(p, m);
                 if (m > LONG_MAX / 2) /* overflow check */
                         return -ENOMEM;

More information about the systemd-devel mailing list