[systemd-devel] [PATCH 0/6] pstore: Tool to archive contents of pstore upon boot/shutdown
Eric DeVolder
eric.devolder at oracle.com
Thu May 16 16:42:03 UTC 2019
OK, will do!
eric
On 5/16/19 9:34 AM, Lennart Poettering wrote:
> On Do, 16.05.19 09:28, Eric DeVolder (eric.devolder at oracle.com) wrote:
>
> Could you please submit this via github as PR? Review is so much nicer
> there, in particular for complex patch sets, and this qualifies as
> complex I think. This also has the benefit that the code is
> automatically analyzed by our CI tools.
>
> https://github.com/systemd/systemd/pulls
>
> Moreover, please make sure to to read our coding style guidelines
> here:
>
> https://systemd.io/CODING_STYLE
>
> Form a very brief glance it appears the code doesn't follow formatting
> rules for example.
>
> Thanks!
>
> Lennart
>
> --
> Lennart Poettering, Berlin
>
More information about the systemd-devel
mailing list