[systemd-devel] need help with undestanding a udev warning

[Andrei Borzenkov]

13.11.2019 18:20, Michael Biebl пишет:
> Hi,
> 
> with v243 I get the following warning in my journal:
> 
> Nov 13 15:38:12 pluto systemd-udevd[319]:
> /lib/udev/rules.d/90-libgpod.rules:19 IMPORT key takes '==' or '!='
> operator, assuming '==', but please fix it.
> Nov 13 15:38:12 pluto systemd-udevd[319]:
> /lib/udev/rules.d/90-libgpod.rules:23 IMPORT key takes '==' or '!='
> operator, assuming '==', but please fix it.
> 
> Looking at the rules file, it shows
> 
> ACTION=="add|change", ENV{USBMUX_SUPPORTED}=="1",
> IMPORT{program}+="/lib/udev/iphone-set-info", GOTO="libgpod_end"
> ..
> ACTION=="add|change", SUBSYSTEM=="usb", ATTR{idVendor}=="05ac",
> ATTR{idProduct}=="129[0-9a]",
> IMPORT{program}+="/lib/udev/iphone-set-info"
> 
> I don't see the error in those udev rules, so I was wondering why udev
> is complaining about them
> 

Likely result of mass-rewrite in

commit 25de7aa7b90c23d33ea50ada1e50c5834a414237
Author: Yu Watanabe <watanabe.yu+github at gmail.com>
Date:   Thu Apr 25 01:21:11 2019 +0200

    udev: modernize udev-rules.c

    This does the following:
    - rename enum udev_builtin_cmd -> UdevBuiltinCmd
    - rename struct udev_builtin -> UdevBuiltin
    - move type definitions to udev-rules.h
    - move prototypes of functions defined in udev-rules.c to udev-rules.h
    - drop to use strbuf
    - propagate critical errors in applying rules,
    - drop limitation for number of tokens per line.