[systemd-devel] Bug in kernel-install

Joe Pater 02joepater06 at gmail.com
Tue Dec 22 18:48:31 UTC 2020


kernel-install seems to be making a mistake generating my
grub.cfg:

kernelopts="root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=

And so on - see the attached config. It seems to be because the root
option ends with 'root'. I can reproduce it every time at the moment
on my machine (fedora 33, kernel 5.9.15). It's only happened the last
3 or 4 kernel updates - I don't know whether that's because the bug is
recent, or because the install script was using a different program
previously.

I'll provide more info if necessary, but I suspect it's a fairly
obvious logic bug.

Thanks,
Joe
-------------- next part --------------
#
# DO NOT EDIT THIS FILE
#
# It is automatically generated by grub2-mkconfig using templates
# from /etc/grub.d and settings from /etc/default/grub
#

### BEGIN /etc/grub.d/00_header ###
set pager=1

if [ -f ${config_directory}/grubenv ]; then
  load_env -f ${config_directory}/grubenv
elif [ -s $prefix/grubenv ]; then
  load_env
fi
if [ "${next_entry}" ] ; then
   set default="${next_entry}"
   set next_entry=
   save_env next_entry
   set boot_once=true
else
   set default="1"
fi

if [ x"${feature_menuentry_id}" = xy ]; then
  menuentry_id_option="--id"
else
  menuentry_id_option=""
fi

export menuentry_id_option

if [ "${prev_saved_entry}" ]; then
  set saved_entry="${prev_saved_entry}"
  save_env saved_entry
  set prev_saved_entry=
  save_env prev_saved_entry
  set boot_once=true
fi

function savedefault {
  if [ -z "${boot_once}" ]; then
    saved_entry="${chosen}"
    save_env saved_entry
  fi
}

function load_video {
  if [ x$feature_all_video_module = xy ]; then
    insmod all_video
  else
    insmod efi_gop
    insmod efi_uga
    insmod ieee1275_fb
    insmod vbe
    insmod vga
    insmod video_bochs
    insmod video_cirrus
  fi
}

terminal_output console
if [ x$feature_timeout_style = xy ] ; then
  set timeout_style=menu
  set timeout=5
# Fallback normal timeout code in case the timeout_style feature is
# unavailable.
else
  set timeout=5
fi
### END /etc/grub.d/00_header ###

### BEGIN /etc/grub.d/01_users ###
if [ -f ${prefix}/user.cfg ]; then
  source ${prefix}/user.cfg
  if [ -n "${GRUB2_PASSWORD}" ]; then
    set superusers="root"
    export superusers
    password_pbkdf2 root ${GRUB2_PASSWORD}
  fi
fi
### END /etc/grub.d/01_users ###

### BEGIN /etc/grub.d/08_fallback_counting ###
insmod increment
# Check if boot_counter exists and boot_success=0 to activate this behaviour.
if [ -n "${boot_counter}" -a "${boot_success}" = "0" ]; then
  # if countdown has ended, choose to boot rollback deployment,
  # i.e. default=1 on OSTree-based systems.
  if  [ "${boot_counter}" = "0" -o "${boot_counter}" = "-1" ]; then
    set default="1"
    set boot_counter=-1
  # otherwise decrement boot_counter
  else
    decrement boot_counter
  fi
  save_env boot_counter
fi
### END /etc/grub.d/08_fallback_counting ###

### BEGIN /etc/grub.d/10_linux ###
insmod part_gpt
insmod ext2
set root='hd0,gpt2'
if [ x$feature_platform_search_hint = xy ]; then
  search --no-floppy --fs-uuid --set=root --hint-bios=hd0,gpt2 --hint-efi=hd0,gpt2 --hint-baremetal=ahci0,gpt2  a8625c4f-e328-4815-a979-c5ab601c1b2d
else
  search --no-floppy --fs-uuid --set=root a8625c4f-e328-4815-a979-c5ab601c1b2d
fi
insmod part_gpt
insmod fat
set boot='hd0,gpt1'
if [ x$feature_platform_search_hint = xy ]; then
  search --no-floppy --fs-uuid --set=boot --hint-bios=hd0,gpt1 --hint-efi=hd0,gpt1 --hint-baremetal=ahci0,gpt1  C75A-769A
else
  search --no-floppy --fs-uuid --set=boot C75A-769A
fi

# This section was generated by a script. Do not modify the generated file - all changes
# will be lost the next time file is regenerated. Instead edit the BootLoaderSpec files.
#
# The blscfg command parses the BootLoaderSpec files stored in /boot/loader/entries and
# populates the boot menu. Please refer to the Boot Loader Specification documentation
# for the files format: https://www.freedesktop.org/wiki/Specifications/BootLoaderSpec/.

# The kernelopts variable should be defined in the grubenv file. But to ensure that menu
# entries populated from BootLoaderSpec files that use this variable work correctly even
# without a grubenv file, define a fallback kernelopts variable if this has not been set.
#
# The kernelopts variable in the grubenv file can be modified using the grubby tool or by
# executing the grub2-mkconfig tool. For the latter, the values of the GRUB_CMDLINE_LINUX
# and GRUB_CMDLINE_LINUX_DEFAULT options from /etc/default/grub file are used to set both
# the kernelopts variable in the grubenv file and the fallback kernelopts variable.
if [ -z "${kernelopts}" ]; then
  set kernelopts="root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root=/dev/mapper/fedora_localhost--live-root ro resume=/dev/mapper/fedora_localhost--live-swap rd.lvm.lv=fedora_localhost-live/root rd.lvm.lv=fedora_localhost-live/swap rhgb quiet "
fi

insmod blscfg
blscfg
### END /etc/grub.d/10_linux ###

### BEGIN /etc/grub.d/10_reset_boot_success ###
# Hiding the menu is ok if last boot was ok or if this is a first boot attempt to boot the entry
if [ "${boot_success}" = "1" -o "${boot_indeterminate}" = "1" ]; then
  set menu_hide_ok=1
else
  set menu_hide_ok=0
fi
# Reset boot_indeterminate after a successful boot
if [ "${boot_success}" = "1" ] ; then
  set boot_indeterminate=0
# Avoid boot_indeterminate causing the menu to be hidden more then once
elif [ "${boot_indeterminate}" = "1" ]; then
  set boot_indeterminate=2
fi
# Reset boot_success for current boot 
set boot_success=0
save_env boot_success boot_indeterminate
### END /etc/grub.d/10_reset_boot_success ###

### BEGIN /etc/grub.d/12_menu_auto_hide ###
if [ x$feature_timeout_style = xy ] ; then
  if [ "${menu_show_once}" ]; then
    unset menu_show_once
    save_env menu_show_once
    set timeout_style=menu
    set timeout=60
  elif [ "${menu_auto_hide}" -a "${menu_hide_ok}" = "1" ]; then
    set orig_timeout_style=${timeout_style}
    set orig_timeout=${timeout}
    if [ "${fastboot}" = "1" ]; then
      # timeout_style=menu + timeout=0 avoids the countdown code keypress check
      set timeout_style=menu
      set timeout=0
    else
      set timeout_style=hidden
      set timeout=1
    fi
  fi
fi
### END /etc/grub.d/12_menu_auto_hide ###

### BEGIN /etc/grub.d/14_menu_show_once ###
if [ x$feature_timeout_style = xy ]; then
  if [ "${menu_show_once_timeout}" ]; then
    set timeout_style=menu
    set timeout="${menu_show_once_timeout}"
    unset menu_show_once_timeout
    save_env menu_show_once_timeout
  fi
fi
### END /etc/grub.d/14_menu_show_once ###

### BEGIN /etc/grub.d/20_linux_xen ###

### END /etc/grub.d/20_linux_xen ###

### BEGIN /etc/grub.d/20_ppc_terminfo ###
### END /etc/grub.d/20_ppc_terminfo ###

### BEGIN /etc/grub.d/30_os-prober ###
### END /etc/grub.d/30_os-prober ###

### BEGIN /etc/grub.d/30_uefi-firmware ###
menuentry 'System setup' $menuentry_id_option 'uefi-firmware' {
	fwsetup
}
### END /etc/grub.d/30_uefi-firmware ###

### BEGIN /etc/grub.d/40_custom ###
# This file provides an easy way to add custom menu entries.  Simply type the
# menu entries you want to add after this comment.  Be careful not to change
# the 'exec tail' line above.
### END /etc/grub.d/40_custom ###

### BEGIN /etc/grub.d/41_custom ###
if [ -f  ${config_directory}/custom.cfg ]; then
  source ${config_directory}/custom.cfg
elif [ -z "${config_directory}" -a -f  $prefix/custom.cfg ]; then
  source $prefix/custom.cfg;
fi
### END /etc/grub.d/41_custom ###


More information about the systemd-devel mailing list