[systemd-devel] SECLABEL issue into udev

[Topi Miettinen]

On 10.3.2020 11.59, Valerii Chernous -X (vchernou - GLOBALLOGIC INC at 
Cisco) wrote:
> Hi Team,
> I send this email again because don't receive answer on previous message.
> 
> I have issue with SECLABEL into systemd udevadm 243 and I see that 
> mainline also have this issue.
> It look like Yu forgot initialize data into commit:
> 25de7aa7b90 (Yu Watanabe                 2019-04-25 01:21:11 +0200 924)
> 
> If I add something like:
> SECLABEL{selinux}="some info"
> to udev rule I got a SIGSEGV into udevadm into this rule.
> On my opinion next one line patch can fix this issue:
> 
> diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c
> index b9b350d1ef..e1e8273468 100644
> --- a/src/udev/udev-rules.c
> +++ b/src/udev/udev-rules.c
> @@ -921,7 +921,7 @@ static int parse_token(UdevRules *rules, const char 
> *key, char *attr, UdevRuleOp
>                           op = OP_ASSIGN;
>                   }
> 
> -                r = rule_line_add_token(rule_line, TK_A_SECLABEL, op, 
> value, NULL);
> +                r = rule_line_add_token(rule_line, TK_A_SECLABEL, op, 
> value, attr);

Looks good to me, but please make a pull request.

-Topi