<div class="gmail_quote"><div dir="ltr">On Fri, Sep 28, 2018, 23:49 Joe Hershberger <<a href="mailto:joe.hershberger@ni.com">joe.hershberger@ni.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">0 can be a valid index returned by the BIOS, so allow that literal while<br>
still checking for 0 as a failed conversion by strtoul(). Also, unsigned<br>
long cannot be negative, so don't misleadingly check for less than 0.<br>
<br>
Signed-off-by: Joe Hershberger <<a href="mailto:joe.hershberger@ni.com" target="_blank">joe.hershberger@ni.com</a>><br>
---<br>
src/udev/udev-builtin-net_id.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/udev/udev-builtin-net_id.c b/src/udev/udev-builtin-net_id.c<br>
index 5341d3788..338a2d4c4 100644<br>
--- a/src/udev/udev-builtin-net_id.c<br>
+++ b/src/udev/udev-builtin-net_id.c<br>
@@ -232,7 +232,7 @@ static int dev_pci_onboard(struct udev_device *dev, struct netnames *names) {<br>
return -ENOENT;<br>
<br>
idx = strtoul(attr, NULL, 0);<br>
- if (idx <= 0)<br>
+ if (idx == 0 && strcmp("0", attr))<br></blockquote></div><div><br></div><div>If error checking is needed, wouldn't it be better to use the error checking that strtoul itself provides?</div><div><br></div><div>("If endptr is not NULL, strtoul() stores the address of the first invalid character in *endptr.")</div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
</blockquote></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><p dir="ltr">Mantas Mikulėnas</p>
</div>