<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="text-align: left; text-indent: 0px; background-color: rgb(255, 255, 255); margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
Hi Systemd-devel Team,</div>
<div style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
I am trying to include a function mnt_new_cache() in systemd.</div>
<div style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
I had changed the signature of a few existing function of systemd.</div>
<div style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
<br>
</div>
<div style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
I get the below compile error.</div>
<div style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
<br>
</div>
<pre style="background-color: rgb(244, 245, 247); margin: 0px; max-height: 30em;"><div style="direction: ltr; text-align: left; text-indent: 0px; white-space: pre-wrap; margin: 0px; font-size: 12px;"><span style="color: rgb(23, 43, 77);">kpit@L-16522:systemd$ ninja -C build
ninja: Entering directory `build'
[833/2203] Linking target systemd
FAILED: systemd
cc -o systemd systemd.p/src_core_main.c.o systemd.p/src_core_crash-handler.c.o -Wl,--as-needed -Wl,--no-undefined -fstack-protector </span><span style="color: rgb(0, 145, 0);">'-Wl,-rpath,$ORIGIN/src/core:$ORIGIN/src/shared'</span><span style="color: rgb(23, 43, 77);"> -Wl,-rpath-link,/home/kpit/a1-velai/code/systemd/4mgithub/another-sd/systemd/build/src/core -Wl,-rpath-link,/home/kpit/a1-velai/code/systemd/4mgithub/another-sd/systemd/build/src/shared -Wl,--start-group src/core/libsystemd-core-256.so src/shared/libsystemd-shared-256.so -Wl,--end-group -Wl,--fatal-warnings -Wl,-z,now -Wl,-z,relro -Wl,--warn-common
/usr/bin/ld: systemd.p/src_core_main.c.o: undefined reference to symbol </span><span style="color: rgb(0, 145, 0);">'mnt_new_cache@@MOUNT_2.19'</span><span style="color: rgb(23, 43, 77);">
/usr/bin/ld: /lib/x86_64-linux-gnu/libmount.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
[842/2203] Generating src/test/test-libsystemd-sym.c with a custom command (wrapped by meson to capture output)
ninja: build stopped: subcommand failed.
kpit@L-16522:systemd$ </span></div></pre>
<div class="elementToProof" style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
<br>
</div>
<div style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
Anything wrong in my compilation though i had included necessary header file.</div>
<div style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
Signature change in function is present and will it be accepted, assuming compilation is successful.</div>
<div style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
I read in contribution webpage, that if there occurs signature change in function, then those change shall be ignored or dimissed or if there is a possbility of having the change as an interface, systemd team will consider after reviewing.</div>
<div style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
<br>
</div>
<div style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
Please let me know the above queries.</div>
<div style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
Thank you</div>
<div class="elementToProof" style="direction: ltr; text-align: left; text-indent: 0px; background-color: white; margin: 0px; font-family: "Times New Roman"; font-size: 12pt; color: black;">
rajmohan</div>
This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print,
retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus
infected mails.
</body>
</html>