<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div id="appendonsend"></div> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <hr style="display: inline-block; width: 98%;"> <div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Cristian Rodríguez <crrodriguez@opensuse.org><br> <b>Sent:</b> Friday, August 23, 2024 11:11 PM<br> <b>To:</b> Rajmohan. R <Rajmohan.R@kpit.com><br> <b>Cc:</b> systemd-devel <systemd-devel@lists.freedesktop.org><br> <b>Subject:</b> Re: [systemd-devel] hint to know the state of the service using function</span> <div> </div> </div> <div style="background-color: rgb(247, 244, 169); font-size: 12pt; color: rgb(255, 0, 0);"> <span style="font-family: "Work Sans", "times new roman", garamond, serif;"><b>Caution: </b></span><span style="font-family: "Work Sans", serif;">This email originated from outside of the KPIT. Do not click links or open attachments unless you recognize the sender and know the content is safe.</span></div> <div style="direction: ltr;"><br> </div> <div style="direction: ltr;"><br> </div> <div style="direction: ltr;">On Fri, Aug 23, 2024 at 11:51 AM Rajmohan. R <<a href="mailto:Rajmohan.R@kpit.com" id="OWA43dd78ea-013f-13a8-8157-ca21d11e35cf" class="OWAAutoLink">Rajmohan.R@kpit.com</a>> wrote:</div> <blockquote style="margin: 0px 0px 0px 0.8ex; padding-left: 1ex; border-left: 1px solid rgb(204, 204, 204);"> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Hi,</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Below is the change related to logging of the units (service) while changing the state [in]active_[exit/enter].</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> I did not get any hint from source code, to know the state change using function, without querying the target system through CLI.</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Could someone from the forum help in providing a hint on how to get the state of the services without querying through CLI.</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Instead of below changes, is there any alternative modification i can do to know the state of the service.</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> diff --git a/src/core/unit.c b/src/core/unit.c</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> index c406bb7ab2..e6ad9b3fbf 100644</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> --- a/src/core/unit.c</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> +++ b/src/core/unit.c</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> @@ -2497,15 +2497,31 @@ void unit_notify(Unit *u, UnitActiveState os, UnitActiveState ns, UnitNotifyFlag</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> if (!MANAGER_IS_RELOADING(m)) {</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> dual_timestamp_get(&u->state_change_timestamp);</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> </div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> - if (UNIT_IS_INACTIVE_OR_FAILED(os) && !UNIT_IS_INACTIVE_OR_FAILED(ns))</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> + if (UNIT_IS_INACTIVE_OR_FAILED(os) && !UNIT_IS_INACTIVE_OR_FAILED(ns)) {</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> u->inactive_exit_timestamp = u->state_change_timestamp;</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> - else if (!UNIT_IS_INACTIVE_OR_FAILED(os) && UNIT_IS_INACTIVE_OR_FAILED(ns))</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> + log_warning("sd: u=%s, inactive_exit="USEC_FMT,</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> + u->id, u->inactive_exit_timestamp.monotonic);</div> <div style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> </blockquote> <div style="direction: ltr;"> </div> <div class="elementToProof" style="direction: ltr;">A patch that does this may be acceptable if you file a PR and use the debug level.. using the warning level for this does not fly..</div> <div class="elementToProof" style="direction: ltr;"><br> </div> <div class="elementToProof" style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> I had already raised a PR for the above change in <a href="https://github.com/systemd/systemd/pull/32430" id="LPlnk"> https://github.com/systemd/systemd/pull/32430</a> PR.</div> <div class="elementToProof" style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> But got review saying intense logging is not required and also timestamps can be queried.</div> <div class="elementToProof" style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> This change will inform that the service name is in which state from inactive_exit while in the target system, which is logged in journal file for later debugging.</div> <div class="elementToProof" style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div class="elementToProof" style="direction: ltr; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Shall i raise new PR only for this change by changing warning to debug.</div> <div class="_Entity _EType_OWALinkPreview _EId_OWALinkPreview _EReadonly_1"> <div id="LPBorder_GTaHR0cHM6Ly9naXRodWIuY29tL3N5c3RlbWQvc3lzdGVtZC9wdWxsLzMyNDMw" class="LPBorder412963" style="width: 100%; margin-top: 16px; margin-bottom: 16px; position: relative; max-width: 800px; min-width: 424px;"> <table id="LPContainer412963" role="presentation" style="padding: 12px 36px 12px 12px; width: 100%; border-width: 1px; border-style: solid; border-color: rgb(200, 200, 200); border-radius: 2px;"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td> <div id="LPImageContainer412963" style="position: relative; margin-right: 12px; height: 120px; overflow: hidden; width: 240px;"> <a target="_blank" id="LPImageAnchor412963" href="https://github.com/systemd/systemd/pull/32430"><img id="LPThumbnailImageId412963" alt="" height="120" style="display: block;" width="240" src="https://opengraph.githubassets.com/15c897f7dec97b7ede6d690084794d8249085b62791f0602284b0bef9c3ef82c/systemd/systemd/pull/32430"></a></div> </td> <td style="width: 100%;"> <div id="LPTitle412963" style="font-size: 21px; font-weight: 300; margin-right: 8px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; margin-bottom: 12px;"> <a target="_blank" id="LPUrlAnchor412963" href="https://github.com/systemd/systemd/pull/32430" style="text-decoration: none; color: var(--themePrimary);">Patches 2 upstream systemd by rajmohanrgithub · Pull Request #32430 · systemd/systemd</a></div> <div id="LPDescription412963" style="font-size: 14px; max-height: 100px; color: rgb(102, 102, 102); font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; margin-bottom: 12px; margin-right: 8px; overflow: hidden;"> Message from commits is given below: systemd: Add more logs for boot procedure analysis systemd-analyze: Add svg scaling options systemd: set suid_dumpable to "suidssafe" mount: Remove fi...</div> <div id="LPMetadata412963" style="font-size: 14px; font-weight: 400; color: rgb(166, 166, 166); font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif;"> github.com</div> </td> </tr> </tbody> </table> </div> </div> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="direction: ltr;"><br> </div> <div style="direction: ltr;"> </div> This message contains information that may be privileged or confidential and is the property of the KPIT Technologies Ltd. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. KPIT Technologies Ltd. does not accept any liability for virus infected mails. </body> </html>