[Bug 23081] New: Handle search by TargetID broken in server/conn.py

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23081

           Summary: Handle search by TargetID broken in server/conn.py
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: Linux (All)
            Status: NEW
          Severity: critical
          Priority: high
         Component: telepathy-python
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: bolaum at gmail.com


Created an attachment (id=28252)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=28252)
Patch to fix the problem described.

This bug was affecting the Requests interface while using telepathy-butterfly.
EnsureChannel() and CreateChannel() were reasing exceptions.

It seems that there was a semantic error regarding TargetID. This patch
changes _alter_properties() to search for TargetID in each handle, that
would be the value returned by get_name(), which is different from
handle's id. The mistake was considering TargetID == handle.get_id()
in this function.
Another change was in EnsureChannel(). It was testing if the channel
existed before fixing the request.
There was a bug in _check_basic_properties(): line 436 was enforcing the
existance of a key that is allowed to be missing.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.