[Bug 23275] Add C++ visibility support

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23275





--- Comment #3 from Andre Moreira Magalhaes <andrunko at gmail.com>  2009-08-13 17:05:49 PST ---
(In reply to comment #1)
> Looks good in principle, but before we merge this, could you please hack up the
> build system so it temporarily produces a shared library, pass it through nm
> and c++filt, attach the result, and check that there aren't symbols that appear
> in our ABI but that we are not prepared to commit to?
> 
> A command like this might be helpful:
> 
> nm .libs/libtelepathy-qt4.a | grep " [DT] " | c++filt | sort -k3
> 

Despite the XXX::Private methods I don't see any other symbol that should not
be there. Should we add TELEPATHY_QT4_NO_EXPORT to all Private structs? Qt does
not do it, as they use shared d pointers in some places, but we don't, at least
for now. I would let it as is.

Also exported non-class methods, enableDebug, registerTypes, ...


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.