[Bug 23274] Implement Hold interface support

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23274





--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-08-17 09:45:10 PST ---
(In reply to comment #4)
> (In reply to comment #2)
> > The simulation of Hold and the tests look reasonable. I'd also like to see a
> > simulation of inability to reacquire a resource (which might look like this:
> > HELD -> PENDING_UNHOLD -> PENDING_HOLD -> HELD, as described by the spec).
> Done
> 
> > Where's your telepathy-glib branch adding this to the example in
> > telepathy-glib? That should have come first :-P
> Here it is
> http://git.collabora.co.uk/?p=user/andrunko/telepathy-glib.git;a=shortlog;h=refs/heads/callable-hold
> :D. Should I file a bug report for this?

No need.

I have three coding-style complaints:

* this is C (and isn't C99), so don't use C++ // comments
* this is C (and isn't C99), so leave a blank line between initialized
declarations and other statements, to make it easier to avoid interleaving
declarations and statements
* there should be blank lines around blocks (if/while/...) anyway, for clarity

(Portability to e.g. Windows suffers if you rely on C99 in C code.)

I'll fix these myself and get someone else to insta-review, since they're just
comments/whitespace changes.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.