[Bug 23275] Add C++ visibility support

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23275


Andre Moreira Magalhaes <andrunko at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch




--- Comment #5 from Andre Moreira Magalhaes <andrunko at gmail.com>  2009-08-18 15:57:44 PST ---
(In reply to comment #4)
> Rejected for now, please re-add patch tag when you've fixed it.
> 
> (In reply to comment #3)
> > Despite the XXX::Private methods I don't see any other symbol that should not
> > be there. Should we add TELEPATHY_QT4_NO_EXPORT to all Private structs?
> 
> Yes, definitely. At the moment, they're part of our shared library ABI; that
> means that we should never remove, rename, or change the semantics of these
> methods, which isn't desirable.
> 
> Also, if we have any private methods on public objects, we should make sure
> they're not exported either.
Done.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.