[Bug 20829] Implement ContactSearch (telepathy-spec 0.17.22 version)

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Aug 26 17:32:03 CEST 2009


http://bugs.freedesktop.org/show_bug.cgi?id=20829





--- Comment #7 from Will Thompson <will.thompson at collabora.co.uk>  2009-08-26 08:32:02 PST ---
(In reply to comment #4)
> > close_all() should just call a close() method on all the
> > channels, and then you don't have to do the stupid "move the hash table aside"
> > dance. Plus, if you explicitly tell the channel to close you're not relying on
> > owning the only reference to it, and it closing as a side-effect of being
> > disposed.
> 
> 
> Fixed.

Having done this, _close_all () shouldn't destroy the HT. finalize can assert
that it's empty, and then destroy it. Then nothing has to deal with it possibly
being NULL.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list