[Bug 24258] Improve valgrind-cleanness

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24258





--- Comment #2 from David Laban <david.laban at collabora.co.uk>  2009-12-03 08:30:11 PST ---


Looks good up to leaks

http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=94dae71c582130aa053c953311b604b6d8f04e28
which required me to look both at the commit message and the full source to see
what was going on. Would having a VALGRIND_TESTS variable make it clearer?

http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=7c0af0be354edad11930d2d0e6de897ae7a57253
If we want to have a test that checks whether valgrind likes our program,
wouldn't it be better to have it fail if valgrind doesn't like us? Are the
suppressions in later commits enough to make this pass?

http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=63ceaa9286a5b5ba1cf30b9954601140b6b7893d
looks good if my guess at what the ... syntax means is correct. I guess you
tested it and it did what you wanted, and it makes the code simpler, which is
more important.

http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=63ceaa9286a5b5ba1cf30b9954601140b6b7893d
-- Have you made any changes that could/should be published to
http://live.gnome.org/Valgrind?

http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=8f69846e0eacf758f35eb3d8d1f6034e243e6bb2
-- I like these kinds of commits.

http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=2fa0d932088ca4d8812bbf3f46f787d51ff94730
http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=2d11ca85e44f33f590b352559c3b8016d7673945
-- Would it be possible to make our tests drop off the bus before exiting, or
is this too much work?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.