[Bug 25422] generate code for Call draft API

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25422





--- Comment #3 from Andre Moreira Magalhaes <andrunko at gmail.com>  2009-12-04 05:50:09 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > The only thing I didn't like is calling TpFuture::registerTypes from inside
> > streamed-media-channel.cpp. I believe the call should be placed somewhere
> > inside registerTypes.
> 
> Two objections to that:
> 
> * it's an implementation detail of StreamedMediaChannel; none of these types
> are meant to be public API
> 
> * Tp::registerTypes is generated code, so it's difficult to modify case-by-case
> :-)
> 
> I wouldn't object to renaming the generated function to _registerTypes and
> making it unconditionally TELEPATHY_QT4_NO_EXPORT, then adding a handwritten
> Tp::registerTypes() that just calls Tp::_registerTypes and
> TpFuture::_registerTypes?
I like that, I would go this route

> 
> > Also I would change the namespace to Tp::Future instead
> > of TpFuture, so using namespace Tp; works
> 
> So you can use Future::ChannelTypeCallInterface? I don't really see the value,
> but if you'd prefer to type :: more often, I suppose I could :-)
> 
Please, our namespace is Tp so anything in tp-qt4 should be using Tp as the
main namespace IMHO. Tp::Future, Tp::Client, Tp::Server, ...


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.