[Bug 25236] TpHandler - a class that implements a Client.Handler

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25236





--- Comment #1 from Jonny Lamb <jonny.lamb at collabora.co.uk>  2009-12-22 10:09:39 PST ---
I've been messing with this today. I've already mentioned a few of these to
you, but I thought I'd write them down here:

 * there needs to be a way to add user_data (or a weak object) to the
HandleChannels callback
 * the coding style is not consistent with the rest of tp-glib
 * it would be great to also implement approver and observer. Maybe at that
point this object should be TpClient instead
 * some documentation needs to be updated (such as whether the arguments in the
HandleChannels callback are guaranteed to be ready/prepared
 * there are some leaks of GErrors in tp_handler_handle_channels

I'm not trying to pretend that I've done a code review of it. I'm merely
pointing out a few things that I think should be fixed.

I'm working on adding approver support right now. It could be made a little
prettier though (at the moment, the variable naming assumes the object is
*just* a handler, for example). I can post my patch here after testing though.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.