[Bug 25766] Review Gabble Google Mail Notification

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25766





--- Comment #2 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2009-12-23 19:34:35 PST ---
(In reply to comment #1)
> 586       g_value_set_boxed (value, mails);
> 
> You can use g_value_take_boxed() here instead. No need to free it then.

That would require to add a ref on every mail hash table. Also, I don't want to
do that since mail hash table could be changed before the get operation
completes. Note that the mail are copied since the boxed type is more then
GPtrArray.

>  - I'm concerned it's not very obvious how support for other mail protocols
>    should be added

There is no XMPP spec for that, and that it's not clear what could be shared
with those unkown protocol, I don't think it worth the effort. The result would
have to be reworked anyway. (The Google specific part is update_unread_mails ()
plus the new-mail signal. Which is everything, except data structure, getter
and subscription.)


Other Items has been fixed:

commit 8b70db3a5473259cf61c3f81e519ed0806b72229
    Mail Notification: Fix coding style

commit 3a4801b26c7c1e60380f83090696f9b4a82c1448
    Mail Notification: Replace g_string_append_printf by g_strdup_printf()

commit 43d7828b1fe70090b254123a56463a6c93c523f8
    Moved macro CHECK_STR_EMPTY to util and use it where possible

commit 74968d90295cd5bc487bd8ea2aa272d64487e44a
    Changed mails_subscribers into HashTable


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.