[Bug 22236] New: gabble_jingle_content_produce_node and transmit_candidates contain similar but subtly-different <content> stanza generators

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jun 11 19:20:08 CEST 2009


http://bugs.freedesktop.org/show_bug.cgi?id=22236

           Summary: gabble_jingle_content_produce_node and
                    transmit_candidates contain similar but subtly-different
                    <content> stanza generators
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: telepathy-gabble
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk


I noticed today that transmit_candidates() and
gabble_jingle_content_produce_node() look suspiciously similar. I was tempted
to replace most of the former with a call to the latter, but they actually
produce different XML. One includes a <transport/> node for both gtalk4 and
gtalk3, while the other only adds one for gtalk4.

I'm scared to touch this without doing a bunch of interop testing so I'm going
to leave it well alone.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the telepathy-bugs mailing list