[Bug 20591] FTBFS: g_warning misses a NULL second parameter.

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=20591


Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |will.thompson at collabora.co.u
                   |                            |k




--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk>  2009-03-11 02:54:07 PST ---
Your proposed patch is wrong: g_warning is printf-like, and doesn't need a NULL
terminator. What's the actual warning you're getting?

The code is also wrong: it shouldn't be building a string and then passing it
as the first argument to g_warning. The correct fix would be to change
g_warning (msg); to g_warning ("%s", msg);


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.