[Bug 24474] [fixed 5.2, pending 5.3] Observers not invoked for channels requested "behind MC's back"

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24474





--- Comment #3 from Sjoerd Simons <sjoerd at luon.net>  2009-11-02 04:00:46 PST ---
+    /* channels that we will only observe should not need approval - so at
+     * least one must be false */
+    g_return_val_if_fail (!(observe_only && needs_approval), NULL);

Are you trying to say observe_only => !needs_approval, because the assertion is
a non-obvious way of writing that and the comment doesn't make it very clear
either


Assuming this still ignores channels on connections that were established
behind mc5's back, the branch looks fine. (apart from probably an improved
comment)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.