[Bug 23780] use TpDebugSender
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Mon Nov 9 22:13:22 CET 2009
http://bugs.freedesktop.org/show_bug.cgi?id=23780
Will Thompson <will.thompson at collabora.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cmaiku at gmail.com
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2009-11-09 13:13:21 PST ---
I reviewed Mike's updated version of this branch.
In haze_debug():
+ domain = g_strdup_printf ("%s/%s", G_LOG_DOMAIN, "haze");
Dupping this for every debug message is unnecessary:
#define LOG_DOMAIN (G_LOG_DOMAIN "/haze")
+ G_LOG_LEVEL_ERROR, /* PURPLE_DEBUG_CRITICAL */
My purple working copy must be really out of date, I can't see any uses of
critical. I trust your judgement that criticals are critical enough to crash
on. :-)
I've fixed the first issue, rebased to remove some spurious merges from Jonny's
history, and merged. It'll be in 0.3.3. Thanks!
commit a3660efd0090f24280a540b1a87015ffdd312b84
Merge: dee146a 31af13f
Author: Will Thompson <will.thompson at collabora.co.uk>
Date: Mon Nov 9 21:11:45 2009 +0000
Merge branch 'debug'
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the telepathy-bugs
mailing list