[Bug 24257] TpAccount, TpAccountManager: prepare never terminates if the object is invalidated

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24257





--- Comment #12 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-11-11 04:17:29 PST ---
Looks OK now, I think. No need to patch the test code to use it now, but in
future, g_error_free / error = NULL can be replaced with g_clear_error
(&error).

(In reply to comment #11)
> > They are both used for programmer errors,
> 
> g_return(_val)_if_fail: the caller of this function was wrong
> 
> g_assert: the internal state of this code is wrong

To put that another way: they're both programmer error, but it's a different
programmer! Suppose I call a function in a module you wrote. g_return...if_fail
indicates that the resulting error might be my fault - passing wrong parameters
or something (I'd have to check the backtrace to be sure, since it could have
been one of your functions passing wrong params to another). g_assert indicates
that the error is your fault (your code internally getting into a "can't
happen" situation).


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.