[Bug 13157] support flag to indicate whether MUC subject is writable

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=13157





--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-11-11 06:20:23 PST ---
(In reply to comment #2)
> muc#roominfo_changesubject isn't actually implemented anywhere as far as I can
> tell.

Google, and Google Code Search, only turn up hits from Telepathy or the XEP.

(In reply to comment #4)
> Do no servers implement muc#roominfo_subject?

That's orthogonal. I believe servers support it, and in principle we could use
it for state-recovery of the initial subject; would you like me to expand the
scope of this branch to do that too?

> Why do you join a different room for the second test in 50c1556? Surely it
> should work just as well if you re-join the same room.

If I remember correctly, there was something weird involving re-disco'ing the
same room. I'll investigate whether the current code is in fact subtly broken,
or whether I just used different rooms to make the assertions more specific...

>      for change_subject in (None, True, False):
>          for send_first in (True, False):
> -            test_subject(q, bus, conn, stream, change_subject, send_first)
> +            for moderator in (True, False):
> +                test_subject(q, bus, conn, stream, change_subject, send_first,
> +                        moderator)
> 
> One problem with this is that python backtraces don't show the values of
> arguments, so it's harder to see which test is failing. While 3×2×2
> duplicated calls to test_subject offend a small part of me, it'd just be 10
> lines rather than 5.

A fair point, I'll change that.

> +  if (self->priv->self_role >=
> +      (self->priv->mortals_can_change_subject
> +       ? ROLE_PARTICIPANT
> +       : ROLE_MODERATOR))
> +    {
> 
> Maybe it'd be clearer to store ->change_subject_level, and put the explanation
> into properties_disco_cb, the point where the disco reply is actually
> interpreted?

You're right, I'll do that.

> Otherwise looks good, these are all nit-picks. Did you test it against real
> servers?

Not yet.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.