[Bug 24385] Implement media in Haze

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Nov 11 18:45:27 CET 2009


http://bugs.freedesktop.org/show_bug.cgi?id=24385





--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk>  2009-11-11 09:45:26 PST ---
Review of 'media' up to f2fe99be4:

+      if (type == PURPLE_MEDIA_INFO_REJECT)
+        reason = "Media session rejected";
+      else
+        reason = "Media session hang up";
+

This is meant to be a message from the peer, like a part message on IRC, not a
string added by the (untranslated) CM. Jingle does actually support these; just
leave it empty if libpurple doesn't expose it (I'm reasonably sure no UI will
ever expose it).

+      if (name != NULL)
+          /* Remove participant */
+          tp_intset_add (set, priv->initial_peer);
+      else
+          /* Remove us */
+          tp_intset_add (set, mixin->self_handle);

If the call's ending, remove both of us from the call. This is vaguely
documented in the group change reasons in the spec, but not documented anywhere
else. I don't think any UI will actually care but it's better to be consistent
with Gabble.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list