[Bug 13157] support flag to indicate whether MUC subject is writable

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=13157





--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-11-11 10:18:42 PST ---
(In reply to comment #4)
> Use assertEquals please.

Done in my branch.

> assertContains.

Done in my branch.

> ns.py

Done in my branch.

> One problem with this is that python backtraces don't show the values of
> arguments, so it's harder to see which test is failing. While 3×2×2
> duplicated calls to test_subject offend a small part of me, it'd just be 10
> lines rather than 5.

Done in my branch.

> Maybe it'd be clearer to store ->change_subject_level, and put the explanation
> into properties_disco_cb, the point where the disco reply is actually
> interpreted?

Done in my branch.

> Did you test it against real servers?

Unfortunately, now that I have, it appears that despite XEP-0045 suggesting
that roomconfig_changesubject could (should?) be in the disco#info, nobody
actually does that.

Meanwhile, we can't just poll the room config, because unless we're an owner,
the server MUST (as per the XEP) refuse to let us read the room config (I
haven't actually checked to see whether any of the servers let unprivileged
people read it anyway, but even if they do violate that requirement, it seems a
bad idea for us to rely on that). Also, polling is rubbish.

So, I think the best we can do for this is to file bugs on various servers
asking them to put roomconfig_changesubject and friends in their disco#info;
until they do, we'll assume that all MUC servers will let us change the
subject.

This probably means that this branch shouldn't be merged to 0.8.x, and perhaps
it should go on hold in 0.9.x too until we get some sort of clarification of
the XEP.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.