[Bug 25042] New: [0.8, 0.9] initialize priv pointers correctly

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25042

           Summary: [0.8, 0.9] initialize priv pointers correctly
           Product: Telepathy
           Version: unspecified
          Platform: Other
               URL: http://git.collabora.co.uk/?p=user/smcv/telepathy-
                    gabble-smcv.git;a=shortlog;h=refs/heads/08-privates
        OS/Version: All
            Status: ASSIGNED
          Keywords: patch
          Severity: normal
          Priority: medium
         Component: gabble
        AssignedTo: simon.mcvittie at collabora.co.uk
        ReportedBy: simon.mcvittie at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


The top four patches of
<http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/08-privates>
improve on our use of priv pointers.

The oldest is a bug waiting to happen, which bit me while working on Bug
#13157; I think at least this one should be merged in 0.8, since it makes our
conventional style for priv pointers compile correctly, but then crash when
used.

The second-oldest removes an uninitialized, unused priv pointer from
GabbleConnectionManager. GabbleConnectionManagerPrivate is never defined, so
this pointer, while useless, can't be dereferenced, and the patch is hence less
important. Up to reviewers whether this is a candidate for 0.8.

The two newest are arguable; I think we should at least have them in 0.9, but
probably not 0.8.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.