[Bug 25158] new media spec implementation needs to support STUN

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25158





--- Comment #1 from Sjoerd Simons <sjoerd at luon.net>  2009-11-18 03:48:42 PST ---
Some review comments for the branch:
* in PROP_STUN_SERVERS to create the ValueArray, use gabble_value_array_build,
which will cut out 
   a   big chunk of code.
* For the test instead of assert X == Y, use the assertEquals method, which
generated better error
   messages  on failure
* For the test, please factor out the Call specicif test into it's own test
function. Also the code 
   that checks the result of the stun check, should just be a function as
currently it jsut seems 
   copy/pasted.
* Also instead of doing,  assert stream_props['Transport'] == 2 # GTALK_P2P use
a constant from 
  constants.py (if there isn't one for it, please add one)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.