[Bug 25278] New: BytestreamMultiple may never signal failure

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25278

           Summary: BytestreamMultiple may never signal failure
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: gabble
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk


I was looking at bytestream-multiple.c from the point of view of trying to make
bytestream_connection_error_cb a bit easier to follow. (Currently it sets
priv->active_bytestream to NULL, calls some method, and then uses
priv->active_bytestream, which is surprising. Also, bytestream_activate_next()
asserts that there are some fallback methods available, rather than failing
gracefully if there are not.)

Looking over it has made me suspicious that BytestreamMultiple's state never
changes to Closed. As far as I can tell, it's only updated in
bytestream_state_changed_cb(), which has a comment explaining (apparently) why
it will never be called for Closed.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.