[Bug 24936] Channel.Type.Call (StreamedMedia 2.0)

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24936





--- Comment #9 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-11-30 11:23:54 PST ---
(In reply to comment #7)
> Stream_Transport_Type takes values Raw_UDP, ICE, GTALK_P2P, MSN and WLM2009.
> Why not Raw_UDP, ICE_UDP, GTalk_P2P, WLM_8_5 and WLM_2009, which would be the
> obvious mapping from the MediaSignalling transports? Is there some other source
> we're trying to remain consistent with? (The handler-capability-tokens in Call
> should be kept in sync with these.)

I've changed these in my branch, except that I left ICE as-is rather than
renaming to ICE_UDP in case we want to use it for ICE-TCP. (Do we?)

(In reply to comment #8)
> (In reply to comment #7)
> > Is Call_Flag_Ringing meant to work on outgoing 1-1 calls, or only on incoming
> > calls?
> Only incoming, not sure what the meaning would be on outgoing calls. In the
> outgoing case the targetid has a flag saying its ringing

I've renamed it to Call_Flag_Locally_Ringing and removed the FIXME.

> > Does Call_Member_Flag_Ringing make sense in conference calls? Is it really
> > useful to be able to have a conference call in which Will is a member and
> > Sjoerd has the Ringing flag?
> 
> You invited me, my phone is ringing but i didn't pick up yet ?

Rationale added.

> > If Call_Flag_Held means locally held (I believe it does), could we rename it
> > accordingly?
> 
> Sure, why not. the more confusion we can take away about which side is holding
> the better 

Done. telepathy-qt4 already had a similar change, in its mapping from generated
code to high-level API.

More questions/gaps, having looked at Content and Stream in detail:

* What significance/rationale does the Content.Name have? I assume that this is
the mostly-opaque content name from Jingle? Do clients really need to be able
to specify this? Do they have to be able to cope with being given a Name that
wasn't what they asked for?

* Content.Disposition seems to be a bit of a mixed bag. Should it really be an
enum, or should it be a flag-set?

* Please explain what's going on with "early media"?

* Is Call.Accept canonically called Accept (as in Call) or Answer (as
referenced in Content)? I've assumed the former.

* Should Sending_State have a state for "I've asked the remote contact to shut
up, but they haven't", for symmetry with Pending_Send?

* Am I right in my clarifications of Stream and sending states? I got quite
confused...

Still to spec-lint: Content.I.Media, Stream.I.Media and Endpoint.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.