[Bug 22768] support Google PMUC

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=22768


Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|telepathy-                  |jonny.lamb at collabora.co.uk
                   |bugs at lists.freedesktop.org  |
                URL|                            |http://git.collabora.co.uk/?
                   |                            |p=user/jonny/telepathy-
                   |                            |gabble.git;a=shortlog;h=refs
                   |                            |/heads/pee-muc
           Keywords|                            |patch




--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk>  2009-10-03 03:46:51 PST ---
Review of Jonny's branch:

util.c has code that could do the namespace lookup semi-properly. That
is to say: lm_message_node_has_namespace() does look like it would work,
except that lm_message_node_get_child_with_namespace() strips off the
prefix if there is one. Soo.... I'd vaguely prefer that we fix that and
then just use it in muc-factory.

You need to find out what Google Talk returns if you disco #pmuc-v1, and
hook that up in connection_iq_disco_cb(). Currently, your branch
advertises the pmuc-v1 bundle, but if another client discos that bundle
it'll return an error.

You should remove the explicit implementation of TpSvcConnection from
connection.c: it's already implemented by TpBaseConnection, and now
we're not overriding any of the methods there's no need to re-implement
it at all.

Using conn as the context for TpDynamicHandleRepo feels a bit like a
hack. Maybe file a bug on tp-glib wondering about a better way?

Can't most of gabble_normalize_room be replaced by gabble_decode_jid() ?
Though it seems a bit weird to call gabble_encode_jid() — in
_gabble_connection_get_canonical_room_name() — and then immediately call
gabble_decode_jid().  :)  I suppose that using gabble_decode_jid() would
make the error messages slightly less useful, since it doesn't say
what's wrong when decoding fails. But they're just D-Bus error messages,
so not really that useful.

_gabble_connection_get_canonical_room_name() should have its leading
underscore removed.

Finally, I don't think you can really say this fixes the pmuc bug: we
don't really support creating them. :P


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.