[Bug 21957] Doesn't implement SimplePresence

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=21957


Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/?|http://git.collabora.co.uk/?
                   |p=user/wjt/telepathy-idle-  |p=user/jonathon/telepathy-
                   |wjt.git;a=shortlog;h=refs/he|idle;a=shortlog;h=refs/heads
                   |ads/presence                |/presence
           Keywords|                            |patch




--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk>  2009-10-11 09:01:55 PST ---
        gboolean dispose_has_run;
+  guint presence_query_id;

Consistency: this should be a tab.

+       /* no need to continue querying member presence after we close the
channel
+        */

This is going to need updating to deal with respawning channels (which I
thought was in master, but maybe isn't).

+        * FIXME: avoid this for large rooms?

Or make it even less frequent?

The commit message for fc8739324 repeats a couple of lines halfway
through a sentence.

update_contact_presence could use tp_asv_new ("message", G_TYPE_STRING,
message, NULL);

Before this is merged, we need to fix the bug where Idle sends at most
one message a second, because otherwise if you have >20 IM channels open
(or fewer and are sending messages for some other reason) the WHO/WHOIS
requests will back up.

I wonder if we should treat contacts whose away message is "Away" (case
insensitively) as if they had no away message. This would mean such
contacts would show up in Empathy with the localized version of "away".

I like the final patch to try to cache the most informative version of
the contact's presence!

The issue of figuring out that the whois reply doesn't contain an away
reply and inferring that they're available is kind of unfortunate.
Perhaps the contact manager could hook into the beginning of the WHOIS
reply, and then if it gets ENDOFWHOIS without getting AWAY decide that
the contacts is available?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.