[Bug 24562] New: Add SECRET flag to the password, *-password params

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24562

           Summary: Add SECRET flag to the password, *-password params
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: butterfly
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: simon.mcvittie at collabora.co.uk


telepathy-glib and telepathy-qt4 currently work around old CMs by assuming that
parameters matching /(^|-)password$/ are passwords, and hence should have the
SECRET flag.

They shouldn't need to do this; the SECRET flag has existed since
telepathy-spec 0.17.2.

Please add the "secret" keyword to all password params in the .manager file,
and bitwise-or the SECRET flag into the corresponding bitfield in the result of
GetParameters().

As far as I can see this currently affects password, http-proxy-password and
https-proxy-password.

Correct .manager syntax:

param-password = s required secret
...
param-http-proxy-password = s secret
...

In GetParameters(), password should have flags =
(telepathy.CONN_MGR_PARAM_FLAG_REQUIRED |
telepathy.CONN_MGR_PARAM_FLAG_SECRET), and the others should have flags =
telepathy.CONN_MGR_PARAM_FLAG_SECRET.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.