[Bug 24120] Refactor the McdDispatcher

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24120





--- Comment #19 from Will Thompson <will.thompson at collabora.co.uk>  2009-10-19 16:02:41 PST ---
Up to 4.3:

I noticed that McdDispatchOperationPrivate has a gchar *claimer. I think that
should be gchar *plaintiff!

+        if (G_LIKELY (dbus_connection))
+            dbus_g_connection_register_g_object (dbus_connection,
+                                                 priv->object_path, object);

Why wouldn't it have one?

I'm a little suspicious about inc_observers() reffing the McdDispatchOperation.
Surely whatever owns the MDO has its own ref? I fear accidental ref leaks.

block_finished, may_finish, check_finished, actually_finished? Pretty confusing
stuff. :)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.