[Bug 24120] Refactor the McdDispatcher

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24120





--- Comment #25 from Will Thompson <will.thompson at collabora.co.uk>  2009-10-20 08:58:45 PST ---
dr4.4-fix-reinvocation:

I'm suspicious of the new logic which invokes the first handler object on the
unique name that originally handled the channel that matches the filter. Could
the McdHandlerMap remember which well-known name handled the channel as well?
Maybe MC could try to use that if it still exists, and fall back to the
first-matching-one behaviour?

+        DEBUG ("Handler %s does not exist in client registry, not "
+               "reinvoking", possible_handlers[0]);
+        mcd_dispatcher_finish_reinvocation (request);
+        return;
+    }

should goto finally;

+mcd_dispatcher_finish_reinvocation (McdChannel *request)
 {
+    _mcd_channel_set_status (request, MCD_CHANNEL_STATUS_DISPATCHED);

Why is that necessary? We only enter this code path in the first place if the
status is Dispatched.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.