[Bug 24120] Refactor the McdDispatcher

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24120





--- Comment #36 from Will Thompson <will.thompson at collabora.co.uk>  2009-10-26 17:08:28 PST ---
Up to 92d18cf0d4:

dr4.6 looks fine.

In get_connection:

+        _mcd_dispatch_operation_get_connection_path
+            (MCD_DISPATCH_OPERATION (self)));

Opening paren should be on the same line as the function name.

+    /* collect object paths into a hash table, to drop duplicates */
+    for (c = channels; c != NULL; c = c->next)
+    {
+        const GList *reqs = _mcd_channel_get_satisfied_requests (c->data);
+

Why would there be duplicate satisfied requests?

Out of interest, what was the rationale for the spec saying:

> If the same NewChannels signal announces some channels that match the filter, and some that do not, then only a subset of the channels (those that do match the filter) are passed to [ObserveChannels].

It makes the code in MC a bit less straightforward than it would be otherwise,
and well-behaved observers still have to deal if MC gives them channels they
don't understand.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.