[Bug 24395] Issues making telepathy-gabble 0.8.3 work on windows

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24395





--- Comment #16 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-10-28 08:28:09 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> There's probably some way to make checks about what method to use in
> configure.ac,
> so that config.h would contain defines like:
> #define fcntl ioctlsocket
> #define F_SETFL FIONBIO
> #define O_NONBLOCK 1
> so that corresponding gibber code would not change much

That's not the right goal. We don't mind our code changing if it's changed in
ways that (a) make us more portable, and (b) still work correctly on Unix.

The right way to do this would be to replace our calls to fcntl() with some
sort of gibber_socket_make_nonblocking() function (think about the purpose, not
the implementation!), and reimplement that do do a different fcntl call on
Windows.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.