[Bug 23639] Port to Wocky

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23639


Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|23640, 23641                |




--- Comment #1 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>  2009-09-02 02:55:00 PST ---
Reply to Will's comments [1] of the wocky branch:

“Loudmouth allows registering handlers”, or (better) “Loudmouth lets you
register handlers”.

fixed


"Maybe WockyXmppNodes itself should have a copy() method?"

typo fixed.
Will ask to sjoerd about the API addition.


"+ /* FIXME: check SSL errors */"

Gio doesn't expose SSL errors. :(


"Stage 2 of connecting. This function is called once the connect operation has
finished. It checks if the connection succeeded, creates and starts the
WockyPorter, then sends a discovery request..."

fixed

"We should be sure to file bugs about these regressions."
I opened #23640 and #23641


"Why else can wocky_porter_close() fail?"
Network error for example: the connection is broken before we send our close
stanza or receive the close stanza from the peer.


"+ /* FIXME: cancel connecting if we are connecting */"

I opened #23642

"Does anything actually need lm_message_node_get_child_with_namespace() to
recursively look down all its children? If not maybe we could delete it
entirely? :)"

git grep lm_message_node_get_child_with_namespace | wc -l
87
So yeah it's used. Parsing code could probably be improved to stop to use this
function but that's out of the scope of this branch.


[1] http://people.collabora.co.uk/~wjt/tmp/Wocky%20port.html


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.