[Bug 23684] New: Gabble advertize an avatar's sha1 in presence stanza without following XEP-0153

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23684

           Summary: Gabble advertize an avatar's sha1 in presence stanza
                    without following XEP-0153
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: telepathy-gabble
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: alban.crequy at collabora.co.uk


telepathy-gabble 0.8.0

XEP-0153 4.3 2. 3rd bullet:
"If the hashes are different, then the client MUST NOT attempt to resolve the
conflict by uploading its avatar image again. Instead, it MUST defer to the
content of the retrieved vCard by resetting its image hash (see below) and
providing that hash in future presence broadcasts."

Gabble does not implement the Resetting the Image Hash described in section
4.4.

When Gabble receives a presence stanza from another Jabber client on the same
account (but different resource), connection_avatar_update_cb() is called and
calls update_own_avatar_sha1(). It just replaces the avatar's hash and publish
it immediately:

  conn->self_presence->avatar_sha1 = g_strdup (sha1);
  if (!_gabble_connection_signal_own_presence (conn, &error))

I fear there can be somehow infinite ping-pong with different Jabber client
implementations which do not follow the XEP-0153...


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.