[Bug 23687] New: Doesn't deal correctly with all BypassApproval handlers exiting

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23687

           Summary: Doesn't deal correctly with all BypassApproval handlers
                    exiting
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: telepathy-mission-control
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: simon.mcvittie at collabora.co.uk


At the moment, it's possible to get MC into this situation:

* NewChannels
* a handler H0 with BypassApproval=FALSE exists
* a handler H1 with BypassApproval=TRUE exists
* MC decides to bypass approvers
* H1 exits
* MC runs handlers
* H1 doesn't exist any more
* H0 is run without approval

or even this:

* NewChannels
* a handler H0 with BypassApproval=FALSE exists
* a handler H1 with BypassApproval=TRUE exists
* MC decides to bypass approvers
* H1 exits, but MC hasn't seen it disappear yet
* MC runs handlers
* H1 is run; calling its HandleChannels method fails
* Only now does MC see that H1 has exited
* H0 is run without approval

We should convert dispatching to have an extra phase: before running approvers,
try to run BypassApproval handlers in preference order. If one of them
succeeds, stop dispatching; if they all fail (or there aren't any), continue to
approvers.

This is likely to require refactoring in the dispatcher code, and is probably
too intrusive for 5.2.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.