[Bug 23819] Add high-level API for FileTransfer

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23819





--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-09-09 11:19:34 PST ---
API review:

* Account::createFileTransfer: \param fileName should probably be called
suggestedFileName to emphasize that this is not how you provide the actual data

* Account::createFileTransfer: document how you send "unspecified hash type"
(from the code, the answer appears to be ((FileHashType) -1)

* We also need convenience API which will look at RequestableChannelClasses and
tell you which properties you're allowed (or required!) to set

* There seems to be no way to refrain from including a filename, content-type,
size, description and date in the request - we should probably specmeet about
this, and decide whether CMs are required to allow all of these for FT channels
even if they won't do anything useful with them?

Code review as I went past (I haven't done a detailed review):

* Sender and Receiver should probably print a line to stderr every time they
see progress, to illustrate how you'd hook up a progress bar

* Receiver::onFileTransferChannelReady: I know it's only an example, but
happily overwrite existing files is bad; could you either use an equivalent of
O_EXCL, or do something like saving the file as ("TelepathyQt4ReceiverExample_"
+ fileName().replace("/", "_"))?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.